[threeten-dev] TzdbZonRulesProvider and providerBind

[Stephen Colebourne]

On 29 January 2013 07:54, Xueming Shen <xueming.shen at oracle.com> wrote:
> A slim down version of the tzdbProvider.java
>
> http://cr.openjdk.java.net/~sherman/jdk8_threeten/tzdbProvider

There should be a blank line before the constructor.

The "Specification for implementors" section is irrelevent on a
non-public class. The class is also not immutable.

The map of versions shoud use Collections.singletonMap or emptyMap
(note that this requires changing the specification in
ZoneRulesProvider)

I think that the version should probably be added to the toString() -
"TZDB[2013a]"

A comment should be added noting that only the latest version is being used.


In general, this is a good simplification.

Stephen