[threeten-dev] Review Request: JapaneseChronology starts with Meiji 6

Stephen Colebourne scolebourne at joda.org
Tue Jul 9 11:56:43 PDT 2013


Looks good to me
Stephen

On 9 July 2013 19:22, roger riggs <roger.riggs at oracle.com> wrote:
> Hi,
>
> In issue #326 <https://github.com/ThreeTen/threeten/issues/326> and JBS
> 8019512 <http://bugs.sun.com/view_bug.do?bug_id=8019512> it is proposed to
> start the JapaneseChronology at Meiji 6
> when the Gregorian calendar was adopted to overlay the Imperial Eras.
> Dates before Meiji 6 are not supported throw an exception.
>
> The changes remove the Seireki Era and define the first supported
> date as Meiji 6, January 1.  Various ranges and tests are updated to match.
>
> Webrev:
>    http://cr.openjdk.java.net/~rriggs/webrev-no-seireki-326/
>
> Please review and comment,  Roger
>
>
>
>


More information about the threeten-dev mailing list