[threeten-dev] Code Freeze tomorrow

[Stephen Colebourne]

On 9 July 2013 22:43, roger riggs <roger.riggs at oracle.com> wrote:
>> #299 is waiting approval from Oracle that the algorithm for smart is
>> acceptable as the default. (It would be awkward in some ways if it
>> wasn't acceptable).
>
> ok, I have ping'ed them to review it, if no response by tomorrow, I would
> push it
> and correct it later as necessary.

My changes are already committed. The review is to check that they are
happy with the logic that went in.


>> #282 is only open as a placeholder for more testing. That won't happen
>> in the next week.
>
> ok
>>
>> I think #321 is desirable, but makes our implementations harder as it
>> probably results in lots of duplicate code. It won't be done this
>> week. (this is a busy work week)
>
> ok, duplicate code is not a plus, we can take another look later.

See the issue for a gist that adds AbstractChronology as a public
class. This avoids the code duplication. With the upcoming generics
removal, the patch can be further enhanced, removing code from
subclass Chronology implementations (unless explicit Javadoc is
needed).

I don't propose we commit the gist/patch before tomorrow, however it
would be good to get feedback on the approach.

Stephen