[threeten-dev] Hijrah Tests Review Request

[Stephen Colebourne]

On 19 June 2013 17:32, chand basha <chand.basha at oracle.com> wrote:
>>> The TestUmmAlQuraChronology class (non TCK) has date creation
>>> indirectly via lines this this:
>>> {1318, 01, 01,   1900, 04, 30},
>>> but the "01" and "04" are octal numbers, not "normal" constants. Octal
>>> numbers may look pretty for dates, but they don't work for "08" and
>>> "09" and thus confuse users browsing this code (looking for example
>>> API usage).
>>>
>>> Is it okay if the numbers are changed from "04" to "4" and so on? If not,
>>> I can change the code to have direct date creation.

Yes, thats what needs to happen. Just change "04" to "4".
Stephen