[threeten-dev] JapaneseDate DAY_OF_YEAR

[Stephen Colebourne]

And there is a disagreemnet as to the start of the Meiji era.
sun.util.calendar.Era says 1868-01-01, wheras our Japanese Era says 1868-09-08.
Is the old Sun class wrong here?

Showa is also different by a day.

The class needs a lot of tidying up I fear.

Here are some more tests, with bugs commented out.
https://gist.github.com/jodastephen/5849354

Who is working to fix this class?
thanks
Stephen



On 24 June 2013 11:26, Stephen Colebourne <scolebourne at joda.org> wrote:
> The patch is fine, except for a cut and paste "Hijrah".
>
> There are lots of issues to work out with Japanese. I'd like to get
> the two patches I put out integrated as well.
> https://github.com/ThreeTen/threeten/issues/299#issuecomment-19831206
> https://github.com/ThreeTen/threeten/issues/318#issuecomment-19896959
>
> The public factory methods are also weird too. ofYearDay(int,int)  is
> public, unlike other date classes.
> Stephen
>
>
>
> On 21 June 2013 22:17, roger riggs <roger.riggs at oracle.com> wrote:
>> A number of problems were found with the DAY_OF_YEAR field in
>> JapaneseChronology/Date.
>> The values for the lengthOfYear() and range were incorrectly computed
>> interfering
>> with the operation of get() and with().
>>
>> The bugs.sun.com issue is: 8017105
>> <http://bugs.sun.com/view_bug.do?bug_id=8017105>
>>
>> Please review and comment:
>>
>> http://cr.openjdk.java.net/~rriggs/webrev-japanese-day-of-year-8017105/
>>
>> Thanks, Roger
>>
>>