[threeten-dev] Please help to review new test code for java.time.Period

roger riggs roger.riggs at oracle.com
Fri Mar 1 07:05:45 PST 2013


Hi Patrick,

These look fine.

I'm not sure if it is a feature or a bug but the way that TestNG works, 
the first failure
terminates the test.  So if anything breaks then only the first case 
will be reported as a failure.

Roger



On 3/1/2013 4:35 AM, patrick zhang wrote:
> Hi Team,
>
> Please help to review new test cases for java.time.Period.
> Impacted method list is bleow.
> plus()
> minus()
> minusDays()
> minusYears()
> minusMonths()
>
> plusYears(). plusMonths() and plusDays are not touched since it has 
> been included. And the new test code dose not introduce data provider. 
> It just follow the old programming style of plusXXX().
>
> webrev:
> http://cr.openjdk.java.net/~pzhang/JSR310/java/time/Period/webrev/
>
> test result:
> http://cr.openjdk.java.net/~pzhang/JSR310/java/time/Period/TCKPeriod.jtr
>
> Regards
> Patrick



More information about the threeten-dev mailing list