[threeten-dev] Fwd: Re: [threeten-develop] Review fix for periodUntil issue 273

[Xueming Shen]

while we are on this, it appears two ChronoLocalDate.periodUntil() methods
are declared as "public abstract ...", any particular reason to do that? or just
a "leftover" of the previous life of CLD as an abstract class, instead of an interface
now?

On 03/01/2013 10:25 AM, Xueming Shen wrote:
>
>
> -------- Original Message --------
> Message-ID: <5130EA4E.40203 at oracle.com>
> Date:     Fri, 01 Mar 2013 09:50:06 -0800
> From:     Xueming Shen <xueming.shen at oracle.com>
> User-Agent:     Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/20130216 Thunderbird/17.0.3
> MIME-Version:     1.0
> To:     threeten-develop at lists.sourceforge.net
> Subject:     Re: [threeten-develop] Review fix for periodUntil issue 273
> References: <512F891E.2000303 at oracle.com> <5130E859.80704 at oracle.com>
> In-Reply-To: <5130E859.80704 at oracle.com>
> Content-Type:     multipart/alternative; boundary="------------010105070200000205030007"
>
>
>
> On 3/1/13 9:41 AM, Xueming Shen wrote:
>> -ChronoDateImple.periodUntil(t, u)
>>   The "convention" is to align the "case" to the "switch" in jdk source code?
>>
>> - Understood it is kinda of 310 convention to have "... == false", but I would suggest to
>>    use the the normal (! X) instead.
>>
>> -ChronoLocalDate.periodUntil(CLD) says the "calculation is performed using the chronology
>>   of this date. If necessary, the input date will be converted to match" (btw, there are two
>>   "the"s here), but all our 4 jdk-provided ChronoLocalDate only handle "same type" of CLD
>
> I meant to say 3.
>
>
>>   now,  (their java doc currently simply is inherited from the super class). Is it possible to have
>>   a better alternative? at least they all have a isodate.
>>
>> -Sherman
>>
>>
>> On 2/28/13 8:43 AM, roger riggs wrote:
>>> Please review bug fix/improvements for:
>>>
>>> PeriodUntil throws exception: unable to calculate period between objects of different types
>>> http://cr.openjdk.java.net/~rriggs/webrev-fix-perioduntil-273/
>>>
>>>
>>> The periodUntil methods do not correctly compute the period
>>> for HijrahDate, ThaiBuddistDate, MinguoDate, and JapaneseDate.
>>> ChronoDateImpl is enhanced to support 12 month based calendars.
>>>
>>> The ValueRange.getIntValue method should throw similar exceptions
>>> when the field is not an int field. Provides better feedback for
>>> the generic Temporal.get access to fields that are not int field.
>>>
>>> Added simple tests to TestHijrahChronology, TestJapaneseChronology,
>>> TestMinguoChronology, and TestHijrahChronology
>>>
>>> Thanks, Roger
>>>
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> Everyone hates slow websites. So do we.
>>> Make your web apps faster with AppDynamics
>>> Download AppDynamics Lite for free today:
>>> http://p.sf.net/sfu/appdyn_d2d_feb
>>>
>>>
>>> _______________________________________________
>>> threeten-develop mailing list
>>> threeten-develop at lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/threeten-develop
>>
>