[threeten-dev] Request for review: quarter text support

Xueming Shen xueming.shen at oracle.com
Mon Mar 4 21:08:11 PST 2013


looks fine for me.

On 3/3/13 12:30 AM, Masayoshi Okutsu wrote:
> I've added quarter text support. Actual names are supported in English 
> only under the default locale data provider. You can specify 
> -Djava.locale.provider=CLDR if localized names are required. I will 
> add localized names into the existing JRE resources (as separate 
> resource bundles) later if I have time.
>
> Also:
>
> - changed DateTimeFormatterBuilder.getLocalizedName to 
> DateTimeTextProvider.getLocalizedResource (package private).
>
> - changed TestTextParser/Printer to specify Locale.ROOT for string 
> case conversions in order to avoid any surprises with the Turkish locale.
>
> - the "MonthNarrow" to "MonthNarrows" change in CLDRConverter.java is 
> a piggy back fix.
>
> Webrev:
> http://cr.openjdk.java.net/~okutsu/310/quartertext/webrev.01/
>
> Thanks,
> Masayoshi
>



More information about the threeten-dev mailing list