[threeten-dev] Please help to review new test cases for java.time.chrono.MinguoChronology

[patrick zhang]

Hi Team,

Please help to review new added test for missed api in 
java.time.chrono.MinguoChronology.
As one initial review version, the webrev includes MinguoChronology 
only. Similar test logic will be applied to IsoChronology, 
HijrahChronology and JapaneseChronology in future webrev.

Description:
1. check new factory method. |*
    date 
<../../../java/time/chrono/MinguoChronology.html#date%28java.time.chrono.Era,%20int,%20int,%20int%29>*(Era 
<../../../java/time/chrono/Era.html> era, int yearOfEra, int month, 
int dayOfMonth)
    ||*dateYearDay 
<../../../java/time/chrono/MinguoChronology.html#dateYearDay%28java.time.chrono.Era,%20int,%20int%29>*(Era 
<../../../java/time/chrono/Era.html> era, int yearOfEra, int dayOfYear)|
2. check now() related function in MinguoChronology and MinguoDate.
        |*dateNow 
<../../../java/time/chrono/MinguoChronology.html#dateNow%28%29>*()|
        |*dateNow 
<../../../java/time/chrono/MinguoChronology.html#dateNow%28java.time.Clock%29>*(Clock 
<../../../java/time/Clock.html> clock)|
        |*dateNow 
<../../../java/time/chrono/MinguoChronology.html#dateNow%28java.time.ZoneId%29>*(ZoneId 
<../../../java/time/ZoneId.html> zone)|
3.  |check | 
<../../../java/time/chrono/MinguoChronology.html#localDateTime%28java.time.temporal.TemporalAccessor%29>|*localDateTime 
<../../../java/time/chrono/MinguoChronology.html#localDateTime%28java.time.temporal.TemporalAccessor%29>*(TemporalAccessor 
<../../../java/time/temporal/TemporalAccessor.html> temporal)|  and  
|*zonedDateTime 
<../../../java/time/chrono/MinguoChronology.html#localDateTime%28java.time.temporal.TemporalAccessor%29>*(TemporalAccessor 
<../../../java/time/temporal/TemporalAccessor.html> temporal)
   In jsr310, we have 3 datetime classes  which implements 
||TemporalAccessor <../../../java/time/temporal/TemporalAccessor.html>:
       LocalDateTime, OffsetDateTime and ZonedDateTime
   According to description in javadoc, all 3 classes can be used in 
||*localDateTime 
<../../../java/time/chrono/MinguoChronology.html#localDateTime%28java.time.temporal.TemporalAccessor%29>*(TemporalAccessor 
<../../../java/time/temporal/TemporalAccessor.html> temporal). But 
LocalDateTime can not be used in ||*zonedDateTime 
<../../../java/time/chrono/MinguoChronology.html#localDateTime%28java.time.temporal.TemporalAccessor%29>*(TemporalAccessor 
<../../../java/time/temporal/TemporalAccessor.html> temporal) since it 
does not contain one Offset. All other ||TemporalAccessor 
<../../../java/time/temporal/TemporalAccessor.html> should throws 
DataTimeException for both methods.|
|   Above logic have been verified in test_localDateTime() and 
test_zonedDateTime().
||4. check ||*zonedDateTime 
<../../../java/time/chrono/MinguoChronology.html#zonedDateTime%28java.time.Instant,%20java.time.ZoneId%29>*(Instant 
<../../../java/time/Instant.html> instant, ZoneId 
<../../../java/time/ZoneId.html> zone)|
      See test_Instant_zonedDateTime(). Similar with |test_zonedDateTime()


webrev:
http://cr.openjdk.java.net/~pzhang/JSR310/java/time/chrono/MinguoChronology/webrev/

test result:
http://cr.openjdk.java.net/~pzhang/JSR310/java/time/chrono/MinguoChronology/TestMinguoChronology.jtr

Regards
Patrick
||  
|