[threeten-dev] Please help to review new test cases for java.time.chrono.Era

[Stephen Colebourne]

You need a blank line at the end of each file.

The "for(FooEra" part is missing a space between for" and "(FooEra" in each file

The indentation within the last loop is too much (shoud be indented by 4).

The tests themselves look fine,
thanks
Stephen


On 5 March 2013 07:34, patrick zhang <patrick.zhang at oracle.com> wrote:
> Hi Team,
>
> Please help to review new added case for java.time.chrono.Era. It only
> checkes Chronology.eras() equals with Era.values() simply.
>
> webrev:
> http://cr.openjdk.java.net/~pzhang/JSR310/java/time/chrono/Era/webrev/
>
> test result:
> http://cr.openjdk.java.net/~pzhang/JSR310/java/time/chrono/Era/TCKHijrahEra.jtr
> http://cr.openjdk.java.net/~pzhang/JSR310/java/time/chrono/Era/TCKIsoEra.jtr
> http://cr.openjdk.java.net/~pzhang/JSR310/java/time/chrono/Era/TCKJapaneseEra.jtr
> http://cr.openjdk.java.net/~pzhang/JSR310/java/time/chrono/Era/TCKMinguoEra.jtr
>
> Regards
> Patrick