[threeten-dev] [threeten-develop] DisplayNames for field names

[roger riggs]

Hi,

On 3/5/2013 8:42 AM, Stephen Colebourne wrote:
> Not sure that the aligned-week-of-year should be assigned the "week" key.
Probably not best. For most fields CLDR does not have locale specific data.

Corresponds to the CLDR 'w' week-of-year and would be appropriate
for IsoFields.WEEK_OF_WEEK_BASED_YEAR and WeekFields.weekOfYear().

Updated:

webrev:
http://cr.openjdk.java.net/~rriggs/webrev-field-displayname-103/ 
<http://cr.openjdk.java.net/%7Erriggs/webrev-field-displayname-103/>


Roger
>
> The ChronoField implementation should throw NPE is loclae is null, 
> which requires an Objects.requireNotNull and a test.
>
> Otherwise good.
> thanks
> Stephen
>
>
> On 2 March 2013 19:02, roger riggs <roger.riggs at oracle.com 
> <mailto:roger.riggs at oracle.com>> wrote:
>
>     Hi,
>
>     Issue#103 <https://github.com/ThreeTen/threeten/network> requests
>     locale based display names for field names.
>     The data is available and it only needs a
>     TemporalField/ChronoField.getDisplayName
>     method plus a little plumbing.
>
>     Please review and comment:
>
>     webrev:
>     http://cr.openjdk.java.net/~rriggs/webrev-field-displayname-103/
>     <http://cr.openjdk.java.net/%7Erriggs/webrev-field-displayname-103/>
>
>     javadoc: TemporalField and ChronoField:
>     http://cr.openjdk.java.net/~rriggs/javadoc-field-displayname-103/
>     <http://cr.openjdk.java.net/%7Erriggs/javadoc-field-displayname-103/>
>