[threeten-dev] Add standalone text styles
Masayoshi Okutsu
masayoshi.okutsu at oracle.com
Tue Mar 5 19:31:26 PST 2013
Here are my comments.
- LDML (UTS#35) calls non-stand-alone styles format styles (forms)
rather than normal styles. I prefer to follow the LDML naming.
- I suspect that it's hard for most developers to understand the
differences between the "normal" and stand-alone constants from the
descriptions. The examples are the same ones, like "Monday".
- It happens to work if you use DateFormat styles as an index to the
time zone names array. But it's not correct to use DateFormat styles.
- TBD part: Calendar defines both format and standalone styles to which
the TextStyles need to map.
If you add the standalone constants to TextStyle, I can take care of the
rest.
Masayoshi
On 3/6/2013 6:32 AM, roger riggs wrote:
> Please review this addition to add TextStyle enum values for
> standalone versions
> of FULL, SHORT, NARROW to support CLDR defined patterns.
>
> http://cr.openjdk.java.net/~rriggs/webrev-addstandalone/
>
> More work is needed after the public API is defined.
>
> Thanks, Roger
>
More information about the threeten-dev
mailing list