[threeten-dev] [threeten-develop] WeekBasedYear fields

[Stephen Colebourne]

"The rules for addition add the number of week-based-years to the
existing value for the week-based-year field. If the resulting
week-based-year only has 52 weeks, then the date will be in week 1 of
the following week-based-year."

This isn't the right behaviour (or is a bad description). Addition
should retain the value of the week and day-of-week. The special case
is if the base week has the value 53 but the result of the calculation
is a week-based-year which has only 52 weeks. In that case, the result
would indeed be in the first week of the following year.

References to "yearOfWeekBasedYear " should be just "weekBasedYear".
Notably, this affects the public method name.

Comment text "This unit is an immutable and thread-safe singleton."
should be "This field is an immutable and thread-safe singleton."

The comment text "week based year" should be dash linked  "week-based-year".

The range of week-based-year is not necessarily the same as the range
of year. It needs to be confirmed.

Comment text "This represents concept of the count" should be This
represents the concept of the count.

My skim of the algorithms looks OK

thanks
Stephen


On 26 March 2013 01:23, Roger Riggs <Roger.Riggs at oracle.com> wrote:
> Please Review:
>
> Issue 64 notes that to correctly support CLDR "Y" and "w", new fields
> are needed that operate correctly for Week and Year of WeekBasedYear.
> This webrev implements additions fields in WeekFields.
>
> http://cr.openjdk.java.net/~rriggs/webrev-WeekBasedYear-64/
>
> An additional factory for creating Dates from YearOfWeekBasedYear,
> WeekOfWeekBasedYear and DayOfWeek plus a chronology.
>
> Roger
>
>
> ------------------------------------------------------------------------------
> Own the Future-Intel&reg; Level Up Game Demo Contest 2013
> Rise to greatness in Intel's independent game demo contest.
> Compete for recognition, cash, and the chance to get your game
> on Steam. $5K grand prize plus 10 genre and skill prizes.
> Submit your demo by 6/6/13. http://p.sf.net/sfu/intel_levelupd2d
> _______________________________________________
> threeten-develop mailing list
> threeten-develop at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/threeten-develop
>