[threeten-dev] Localized GMT offset

[Stephen Colebourne]

Looks good to me
Stephen

On 26 March 2013 20:00, Xueming Shen <xueming.shen at oracle.com> wrote:
> Webrev has bee updated as suggested.
>
> http://cr.openjdk.java.net/~sherman/jdk8_threeten/fmtOffsetPrefixed/
>
> thanks,
> -Sherman
>
>
> On 03/26/2013 12:20 PM, Stephen Colebourne wrote:
>>
>> On 26 March 2013 18:08, Xueming Shen<xueming.shen at oracle.com>  wrote:
>>>>
>>>> I think we're on the right lines here.
>>>>
>>>> I think that TextStyle makes more sense than FormatStyle, but does
>>>> CLDR have an opinion?
>>>
>>> I picked FormatStyle mostly because (1) the "appendLocalized()" uses
>>> FormatStyle
>>> and (2) FormatStyle has a "long" instead of the "full" in text style. I
>>> don't have a
>>> strong feeling about this one, either works fine with me.
>>
>> I think that TextStyle is better, as I could foresee a future CLDR
>> change where there are different formats for standalone offsets.
>>
>> I also think that you shouldn't refer to prefixes, as CLDR allows the
>> localized format to be "{0} GMT".
>> Otherwise looks good.
>> Stephen
>
>