[threeten-dev] [threeten-develop] Review or DateTimeFormatter 'Y' and 'w'

[Stephen Colebourne]

DateTimeFormatterBuilder - the comment lines beneath the map of fields
(line 1662) should be updated to say what Y does
"310 - w, W and Y are localized forms matching LDML"

DateTimeFormatterBuilder - The comments are wrong for u, y and Y for 4
letters, as the code uses EXCEEDS_PAD, not NORMAL
shoud be "yyyy    4      appendValue(ChronoField.YEAR_OF_ERA, 4, 19,
SignStyle.EXCEEDS_PAD);"

DateTimeFormatterBuilder - The toString() in the printer-parser now
has the same text for e and c. I didn't have a problem with the old
style, although the new style is probably clearer.

TCKWeekFields, line 492 has incorrect indentation

These are all minor things, so I'm happy for direct push without
further review if you want.
thanks
Stephen



On 28 March 2013 19:49, roger riggs <roger.riggs at oracle.com> wrote:
> Please review updates to DateTimeFormatter* to implement
> CLDR behavior for pattern letters 'Y' and 'w'.
>
> Hooked the WeekFields for WeekBasedYear to the corresponding pattern
> letters.
> Added tests, updated the javadoc/spec.
>
> Webrev:
>    http://cr.openjdk.java.net/~rriggs/webrev-WeekBasedYear-64/
>
> Thanks, Roger
>
>
>
>
> ------------------------------------------------------------------------------
> Own the Future-Intel(R) Level Up Game Demo Contest 2013
> Rise to greatness in Intel's independent game demo contest. Compete
> for recognition, cash, and the chance to get your game on Steam.
> $5K grand prize plus 10 genre and skill prizes. Submit your demo
> by 6/6/13. http://altfarm.mediaplex.com/ad/ck/12124-176961-30367-2
> _______________________________________________
> threeten-develop mailing list
> threeten-develop at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/threeten-develop
>