[threeten-dev] Please help to review new test cases for java.time.ZoneOffset

[Patrick Zhang]

It has been updated.

Webrev:
http://cr.openjdk.java.net/~pzhang/JSR310/java/time/ZoneOffset/webrev/

Test result:
http://cr.openjdk.java.net/~pzhang/JSR310/java/time/ZoneOffset/TCKZoneOffset.jtr

Regards
Patrick

On 4/29/13 7:55 PM, Stephen Colebourne wrote:
> test_adjustDate_nullLocalDate should be named test_adjustInto_dateOnly
>
> Otherwise looks good.
> Stephen
>
>
> On 28 April 2013 05:44, Patrick Zhang<patrick.zhang at oracle.com>  wrote:
>> Hi Team,
>>
>> Please help to review new added test case for ZoneOffset.
>> Roughly it is only for adjustInto() method. And the test logic is simple:
>>
>> When it is "adjustInto" to one ZonedDateTime, offset of new generated
>> ZonedDateTime will NOT be changed. It is because ZonedDateTime initialized
>> by specific zoneId will have one fixed offset, if we ignore the DST.
>> When it is "adjustInto" to one OffsetDateTime, offset of new generated
>> OffsetDateTime will be changed.
>>
>> Webrev:
>> http://cr.openjdk.java.net/~pzhang/JSR310/java/time/ZoneOffset/webrev/
>>
>> Test result:
>> http://cr.openjdk.java.net/~pzhang/JSR310/java/time/ZoneOffset/TCKZoneOffset.jtr
>>
>> Regards
>> Patrick