[threeten-dev] Review for parsing 2 to 4 years #218

Stephen Colebourne scolebourne at joda.org
Wed May 1 08:22:16 PDT 2013


TestReducedParser Line 199
"Parse data and values with the in strict parsing mode."
comment workding change

On 1 May 2013 15:43, roger riggs <roger.riggs at oracle.com> wrote:
> I did prefer it to use minWidth but earlier comments suggests being
> consistent
> with SimpleDateFormat which is explicitly 2 digits.

I think we get the 2 digit compatability via the patern, so thats OK.


> The leniency for the sign character is separate from the leniency for the
> field width.  At the point that ReducedPrinterParser is checking the width
> it receives only the number of digits parsed.  So the current code does not
> interpret +1 or -1 as reduced.

What about this test case:
{YEAR, 2, 4, 2000, "+10", 0, strict(0, null), lenient(3, 2010)},
Should that not result in year 10, as no signs should be allowed for base value?

Stephen


More information about the threeten-dev mailing list