[threeten-dev] Please help to review new test cases for java.time.OffsetTime

[Patrick Zhang]

It has been updated.
1. Change "test_periodUntil_InvalidTemporalUnit" to check 
DateTimeException while using MONTHS as unit for 
offsetTime1.periodUntil(offsetTime1)
2. Create one new "test_periodUntil_invalidType" to check  
DateTimeException for offsetTime.periodUntil.(0ffsetDateTIme).

Webrev:
http://cr.openjdk.java.net/~pzhang/JSR310/java/time/OffsetTime/webrev/

Test result:
http://cr.openjdk.java.net/~pzhang/JSR310/java/time/OffsetTime/TCKOffsetTime.jtr

Regards
Patrick



On 4/29/13 8:01 PM, Stephen Colebourne wrote:
> "test_periodUntil_InvalidTemporalUnit" should named
> "test_periodUntil_invalidType" as it tests periodUtil between
> OffsetTime and OffsetDateTIme.
>
> "test_periodUntil_InvalidTemporalUnit" should test a period in an
> invalid unit, such as querying the period in MONTHS
>
> Otherwise looks good.
> Stephen
>
>
>
>
> On 28 April 2013 05:44, Patrick Zhang<patrick.zhang at oracle.com>  wrote:
>> Hi Team,
>>
>> Please help to review new test cases for OffsetTime.periodUntil().
>>
>> The test logic is simple, as description in javadoc:
>> =============
>> When two OffsetTime have different Offset, then the specified end time will
>> be normalized to have same offset with start time.
>> =============
>> Then 01:01:01+10:00 to 02:01:01+10:00 should be 1 hour while 01:01:01+10:00
>> to 02:01:01+9:00 should be 2 hours.
>>
>>
>> Webrev:
>> http://cr.openjdk.java.net/~pzhang/JSR310/java/time/OffsetTime/webrev/
>>
>> Test result:
>> http://cr.openjdk.java.net/~pzhang/JSR310/java/time/OffsetTime/TCKOffsetTime.jtr
>>
>> Regards
>> Patrick