[threeten-dev] Review request: JapaneseChronology/JapaneseDate fixes

[roger riggs]

Hi Masayoshi,

I don't think leniency is needed for 0 or negative yearOfEra values and
for years greater than the era it is of limited usefulness.

The rest looks fine as far as I can tell.

Roger


On 5/1/2013 4:59 AM, Masayoshi Okutsu wrote:
> Hi,
>
> I've fixed various JapaneseChronology and JapaneseDate implementation 
> bugs, mostly missing or incorrect validations.
>
> Here's the webrev.
> http://cr.openjdk.java.net/~okutsu/310/japanesechrono/webrev.00/
>
> One question is, why 0 and -10 of Heisei are considered as valid 
> yearOfEra values in TCKJapaneseChronology.java? Please let me know if 
> prolepticYear(era, yearOfEra) should rather be lenient (in the current 
> era).
>
> Thanks,
> Masayoshi
>