[threeten-dev] Please help to review new added test cases for java.time.Chronology

Patrick Zhang patrick.zhang at oracle.com
Thu May 9 01:32:17 PDT 2013


Hi Team,

Please help to review new added test cases for java.time.Chronology.
Impacted apis:
date(Era era, int yearOfEra, int month, int dayOfMonth)
dateYearDay(Era era, int yearOfEra, int dayOfYear)
dateNow()
dateNow(Clock clock)
dateNow(ZoneId zone)
getDisplayName()

And in this webrev there is one fix for test code.
According to 
http://sqeweb.us.oracle.com/jsn/users/patrick/threeten/build/linux-x86-normal-server-release/docs/api/, 
1912-02-19 should belong to Meiji Era nor Taisho. So change the date to 
1916-02-19 which is in Taisho.

webrev:
http://cr.openjdk.java.net/~pzhang/JSR310/java/time/chrono/Chronology/webrev/
test result:
http://cr.openjdk.java.net/~pzhang/JSR310/java/time/chrono/Chronology/TCKChronology.jtr

Regards
Patrick



More information about the threeten-dev mailing list