[threeten-dev] Updated Hijrah Data

[Stephen Colebourne]

Change looks good. And thanks to Dr. Fayez Alhargan.

I would note that the choice of min/max year and single era means that
resolveDate() must be overridden in HijrahChrono to get era handling
correct (or the superclass changed to take min/max year/era into
account).

Stephen


On 17 May 2013 18:46, roger riggs <roger.riggs at oracle.com> wrote:
> Hi,
>
> Thanks to the contribution of Dr. Fayez Alhargan of KACST, accurate and
> complete data
> for the Umm Al-Qura Islamic calendar is available and is being added to
> OpenJDK.
> The tests have been updated and minor javadoc corrections are included.
>
> The webrev is:
>    http://cr.openjdk.java.net/~rriggs/webrev-hijrah-data/
>
> Please review and comment.
>
> Thanks, Roger
>
>