[threeten-dev] Please help to review new test cases for java.time.temporal.ChronoField and ChronoUnit

Stephen Colebourne scolebourne at joda.org
Thu May 23 02:56:12 PDT 2013


Looks good to me.
Stephen

On 23 May 2013 05:11, Patrick Zhang <patrick.zhang at oracle.com> wrote:
> Hi Team,
>
> Please help to review new tests for java.time.temporal.ChronoField and
> ChronoUnit.
>
> Impacted methods in ChronoField:
> getBaseUnit()
> getRangeUnit()
> isDateBased()
> isTimeBased()
> isSupportedBy(TemporalAccessor temporal)
> getFrom(TemporalAccessor temporal)
> range()
> rangeRefinedBy(TemporalAccessor temporal)
> valueOf()
> values()
>
> Impacted methods in ChronoUnit:
> isDateUnit()
> isTimeUnit()
> isDurationEstimated()
> isSupportedBy()
> addTo()
> between()
> values()
> valueOf()
>
>
> webrev:
> http://cr.openjdk.java.net/~pzhang/JSR310/java/time/temporal/webrev/
>
> test result:
> http://cr.openjdk.java.net/~pzhang/JSR310/java/time/temporal/TCKChronoField.jtr
> http://cr.openjdk.java.net/~pzhang/JSR310/java/time/temporal/TCKChronoUnit.jtr
>
> Regards
> Patrick


More information about the threeten-dev mailing list