[threeten-dev] Please help to review new test cases for java.time.chrono package
Patrick Zhang
patrick.zhang at oracle.com
Tue May 28 00:49:13 PDT 2013
Hi Team,
Please help to review the tests added for java.time.chrono.MinguoDate,
JapaneseDate and ThaiBuddhistDate.
As final effort to cover all missed api, the code is put in related
Chronology test class then we can reuse something.
Test description based on MinguoChronology:
1. MinguoDate.from(isoDate) should return corresponding MinguoDate
instance correctly. It should work same as
MinguoChronology.INSTANCE.date(isoDate).
2. Check the difference of isEqual() and equals().
3. Move function of isLeapYear() into separate test. And length of
February of leap year should be 29 since its definition for "leap year"
is same with ISO chronology.
4. Fixed some format issue in test class.
webrev:
http://cr.openjdk.java.net/~pzhang/JSR310/java/time/chrono/Date/webrev/
test result:
http://cr.openjdk.java.net/~pzhang/JSR310/java/time/chrono/Date/TCKJapaneseChronology.jtr
http://cr.openjdk.java.net/~pzhang/JSR310/java/time/chrono/Date/TCKMinguoChronology.jtr
http://cr.openjdk.java.net/~pzhang/JSR310/java/time/chrono/Date/TCKThaiBuddhistChronology.jtr
Regards
Patrick
More information about the threeten-dev
mailing list