hg: tiered-attrib/dev/langtools: 4 new changesets

[Maurizio Cimadamore]

Cool - on the erroneous arg check, note that Resolve uses this routine 
in Type

public static booleanisErroneous(List<Type> ts) {
     for(List<Type> l = ts;l.nonEmpty();l = l.tail)
         if(l.head.isErroneous())return true;
     return false;
}


Isn't that equivalent to what you have?

Also, here:

+            this.speculativeType = inferenceContext != null ? inferenceContext.asInstType(aType) : null;


Shouldn't this be:

+            this.speculativeType = inferenceContext != null ? inferenceContext.asInstType(aType) : aType;


?

Maurizio

On 20/03/15 22:09, vicente.romero at oracle.com wrote:
> Changeset: 64907ae401a3
> Author:    vromero
> Date:      2015-03-20 15:05 -0700
> URL:       http://hg.openjdk.java.net/tiered-attrib/dev/langtools/rev/64907ae401a3
>
> structural types should keep speculative types to provide better diagnostics
>
> ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TieredAttrUtils.java
>
> Changeset: e43275ce7db7
> Author:    vromero
> Date:      2015-03-20 15:06 -0700
> URL:       http://hg.openjdk.java.net/tiered-attrib/dev/langtools/rev/e43275ce7db7
>
> set method return type to error if any argument is erroneous
>
> ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java
> ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TieredAttrUtils.java
>
> Changeset: 34b0a2fe333d
> Author:    vromero
> Date:      2015-03-20 15:06 -0700
> URL:       http://hg.openjdk.java.net/tiered-attrib/dev/langtools/rev/34b0a2fe333d
>
> tiered attribution needs to special-case polymorphic signature methods
>
> ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java
> ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Resolve.java
>
> Changeset: 3b25be40fc3d
> Author:    vromero
> Date:      2015-03-20 15:08 -0700
> URL:       http://hg.openjdk.java.net/tiered-attrib/dev/langtools/rev/3b25be40fc3d
>
> simplifying visitApply target checking
>
> ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java
>