RFR (M): Make TSAN a build-time JVM feature

[Man Cao]

Done.

-Man


On Mon, Apr 1, 2019 at 8:35 AM Arthur Eubanks <aeubanks at google.com> wrote:

> nit: in make/hotspot/lib/JvmFeatures.gmk don't add a trailing slash, the
> others JVM_EXCLUDE_PATTERNS mostly don't have a trailing slash. No need for
> new webrev.
>
> otherwise LGTM
>
> On Fri, Mar 29, 2019 at 7:51 PM Jean Christophe Beyler <
> jcbeyler at google.com> wrote:
>
>> Agreed Man on all points,
>>
>> LGTM,
>> Jc
>>
>> On Fri, Mar 29, 2019 at 7:14 PM Man Cao <manc at google.com> wrote:
>>
>> > Note that I moved the two new files for TSAN into the directory
>> > "share/tsan".
>> > Looking at our internal TSAN code, there will be more new files for
>> TSAN to
>> > add in the future. A separate directory seems cleaner.
>> >
>> > -Man
>> >
>> >
>> > On Fri, Mar 29, 2019 at 7:10 PM Man Cao <manc at google.com> wrote:
>> >
>> > > Hi,
>> > >
>> > > Could I get review for this:
>> > > http://cr.openjdk.java.net/~manc/tsan/20190329/webrev.00/
>> > >
>> > > It makes it possible to disable TSAN at build time, using
>> > > "--with-jvm-features=-tsan". My initial purpose was to add a "#ifdef"
>> > macro
>> > > for TSAN, but it seems making TSAN a JVM feature is the right way to
>> go
>> > for
>> > > the long term.
>> > >
>> > > Tested by building with and without TSAN, and running LD_PRELOAD.
>> > >
>> > > -Man
>> > >
>> >
>>
>>
>> --
>>
>> Thanks,
>> Jc
>>
>