INCLUDE_TSAN inconsistent between launcher and hotspot
Arthur Eubanks
aeubanks at google.com
Fri Apr 19 18:42:56 UTC 2019
In a previous change it was mentioned that we should use "#if
INCLUDE_TSAN", not "#ifdef INCLUDE_TSAN".
I looked at all INCLUDE_TSAN, and the one
in src/java.base/share/native/launcher/main.c is different from the ones in
hotspot. I tried the following change:
http://cr.openjdk.java.net/~aeubanks/tsanmainincludetsan/webrev.00/src/java.base/share/native/launcher/main.c.udiff.html
but I get
error: "INCLUDE_TSAN" is not defined, evaluates to 0 [-Werror=undef]
In src/hotspot/share/utilities/macros.hpp in hotspot, there's
#ifndef INCLUDE_TSAN
#define INCLUDE_TSAN 1
#endif
Do we need something like this in the launcher? Or is the difference ok?
More information about the tsan-dev
mailing list