[RFR]: Lock instrumentation

Jean Christophe Beyler jcbeyler at google.com
Tue Apr 23 16:49:02 UTC 2019


Hi Arthur,

Looks good to me, I was looking at if we could factorize a bit the
assertions and what-not but for now it's fine.

(I did notice that we let creep in the #endif // INCLUDE_TSAN which does
not seem to be that much the style of the general code base so we might
want to remove them at some point)

But that's a detail, LGTM,
Jc


On Tue, Apr 23, 2019 at 9:29 AM Arthur Eubanks <aeubanks at google.com> wrote:

> This changes adds instrumentation for various locks in the JVM. (not
> including JVMTI)
> http://cr.openjdk.java.net/~aeubanks/tsanlock/webrev.00
>
> Note the NonRacy tests still don't pass for some reason. I believe it's due
> to dynamic linking of libtsan.so.
>


-- 

Thanks,
Jc


More information about the tsan-dev mailing list