RFR: Move -XX:+ThreadSanitizer to the testing process
Alex Menkov
alexey.menkov at oracle.com
Tue Apr 23 20:54:21 UTC 2019
I thought agentvm is the default, but looks like it's true only for
"make run-test":
https://openjdk.java.net/jtreg/faq.html#what-are-the-agentvm-and-othervm-modes
--alex
On 04/23/2019 13:06, Arthur Eubanks wrote:
> I don't think it's the "default", it's only necessary when you need to spin
> up a new VM to run the test (which we're doing ourselves manually). It's
> slower and unnecessary in our case.
> I think it's almost always only used when you need new a new VM with
> different flags.
>
> On Tue, Apr 23, 2019 at 1:03 PM Jean Christophe Beyler <jcbeyler at google.com>
> wrote:
>
>> As far as I can tell, othervm just is an isolation mode for the various
>> actions; it should change nothing to have it or not and I think it is the
>> "default" to use as things will be more isolated.
>>
>> I'd vote to keep it to be honest if what I am reading/understanding is
>> correct,
>> Jc
>>
>> On Tue, Apr 23, 2019 at 12:59 PM Arthur Eubanks <aeubanks at google.com>
>> wrote:
>>
>>> Now the tests don't need to be in "othervm" right?
>>>
>>> On Tue, Apr 23, 2019 at 12:57 PM Jean Christophe Beyler <
>>> jcbeyler at google.com> wrote:
>>>
>>>> Hi all,
>>>>
>>>> Please review this webrev that moves tsan being enabled in the subprocess
>>>> and not the process being tested.
>>>>
>>>> Webrev: http://cr.openjdk.java.net/~jcbeyler/tsan_flag/
>>>>
>>>> Thanks,
>>>> Jc
>>>>
>>>
>>
>> --
>>
>> Thanks,
>> Jc
>>
More information about the tsan-dev
mailing list