RFR: Move -XX:+ThreadSanitizer to the testing process

[Jean Christophe Beyler]

Done, thanks for the reviews :)
Jc

On Tue, Apr 23, 2019 at 2:18 PM Man Cao <manc at google.com> wrote:

> Looks and sounds good.
> Just make sure to also remove "-XX:+ThreadSanitizer" from this commit:
> http://hg.openjdk.java.net/tsan/dev/rev/bc4100503ba4
>
> -Man
>
>
> On Tue, Apr 23, 2019 at 1:57 PM Jean Christophe Beyler <
> jcbeyler at google.com> wrote:
>
>> Yeah I noticed that too.
>>
>> It also seems that I need othervm if native is defined so for the native
>> racy tests, I need them. I removed it the non native test though.
>>
>> Let me know what you think, I can generate a new webrev if you like,
>> Jc
>>
>> On Tue, Apr 23, 2019 at 1:54 PM Alex Menkov <alexey.menkov at oracle.com>
>> wrote:
>>
>> > I thought agentvm is the default, but looks like it's true only for
>> > "make run-test":
>> >
>> >
>> >
>> https://openjdk.java.net/jtreg/faq.html#what-are-the-agentvm-and-othervm-modes
>> >
>> > --alex
>> >
>> > On 04/23/2019 13:06, Arthur Eubanks wrote:
>> > > I don't think it's the "default", it's only necessary when you need to
>> > spin
>> > > up a new VM to run the test (which we're doing ourselves manually).
>> It's
>> > > slower and unnecessary in our case.
>> > > I think it's almost always only used when you need new a new VM with
>> > > different flags.
>> > >
>> > > On Tue, Apr 23, 2019 at 1:03 PM Jean Christophe Beyler <
>> > jcbeyler at google.com>
>> > > wrote:
>> > >
>> > >> As far as I can tell, othervm just is an isolation mode for the
>> various
>> > >> actions; it should change nothing to have it or not and I think it is
>> > the
>> > >> "default" to use as things will be more isolated.
>> > >>
>> > >> I'd vote to keep it to be honest if what I am reading/understanding
>> is
>> > >> correct,
>> > >> Jc
>> > >>
>> > >> On Tue, Apr 23, 2019 at 12:59 PM Arthur Eubanks <aeubanks at google.com
>> >
>> > >> wrote:
>> > >>
>> > >>> Now the tests don't need to be in "othervm" right?
>> > >>>
>> > >>> On Tue, Apr 23, 2019 at 12:57 PM Jean Christophe Beyler <
>> > >>> jcbeyler at google.com> wrote:
>> > >>>
>> > >>>> Hi all,
>> > >>>>
>> > >>>> Please review this webrev that moves tsan being enabled in the
>> > subprocess
>> > >>>> and not the process being tested.
>> > >>>>
>> > >>>> Webrev: http://cr.openjdk.java.net/~jcbeyler/tsan_flag/
>> > >>>>
>> > >>>> Thanks,
>> > >>>> Jc
>> > >>>>
>> > >>>
>> > >>
>> > >> --
>> > >>
>> > >> Thanks,
>> > >> Jc
>> > >>
>> >
>>
>>
>> --
>>
>> Thanks,
>> Jc
>>
>

-- 

Thanks,
Jc