[RFR]: Field suppression list

[Man Cao]

Looks good. Some nits below, no need for another webrev.

In classFileParser.cpp:
37 #include "classfile/tsanIgnoreList.hpp"
This can be guarded by TSAN_ONLY.

In
http://cr.openjdk.java.net/~aeubanks/tsanfieldsupp/webrev.00/src/hotspot/share/classfile/tsanIgnoreList.cpp.html,
some whitespace can be improved:

  62  protected:
  63   const Symbol*        _class_name;
  64   const Symbol*        _field_name;
  65   Mode           _class_mode;
  66   Mode           _field_mode;
  67   FieldMatcher* _next;

No need to have more than 1 space.

 135     _exact_match = new FieldMatcher(class_symbol, field_symbol, class_mode,
 136                                    field_mode, _exact_match);

Need to align second line.

 156   char token[MAX_LINE_SIZE];
 157   int  pos = 0;
 158   int  c = fgetc(stream);

No need to have more than 1 space.

-Man


On Mon, Jul 1, 2019 at 3:59 PM Arthur Eubanks <aeubanks at google.com> wrote:

> webrev:
> http://cr.openjdk.java.net/~aeubanks/tsanfieldsupp/webrev.00/index.html
>
> Add a new flag -XX:ThreadSanitizerIgnoreFile=path/to/ignorefile. The file
> is parsed for patterns like
>
> # To whitelist field myBaz in a class named com.foo.Bar
> com.foo.Bar myBaz
> # Every field with primitive type starting with my in that class:
> com.foo.Bar my*
> # And every primitive field in package com.foo:
> com.foo.* *
>
> and those fields are ignored in regards to TSAN.
>