[RFR]: Field suppression list

[Arthur Eubanks]

On Tue, Jul 9, 2019 at 3:41 PM Jean Christophe Beyler <jcbeyler at google.com>
wrote:

> Hi Arthur,
>
> FWIW, the comment here:
>
>>         - I would really find a '#' and replace it with '\0' if found
>>
>> If we have to check for '#' either way, I think bailing out when we see
> it is fine.
>
> I don't entirely agree. User input is always error-prone and I could
> easily do:
>
> # Ignore this comment
>  # But ignore this one
> whatever #Incomplete line but now accepted by the system since it does a
> "%s %s"
> whatever really #But this also is accepted because sscanf does not look
> afterwards...
>
> In theory, we'd like the system to ignore the three first lines at least
> since they are not correct, your code will accept the second and third...
>
> If you don't want to fix it now that's ok but it should be something fixed
> a bit to be a little bit more robust, no?
> Jc
>
You convinced me:
http://cr.openjdk.java.net/~aeubanks/tsanfieldsupp/webrev.02/