Build breakage

Arthur Eubanks aeubanks at google.com
Tue Jul 16 21:31:58 UTC 2019


RFR:
http://cr.openjdk.java.net/~aeubanks/tsanmissinginclude/webrev.00/index.html
should fix the missing includes. Will considering moving tsanIgnoreList in
another change.

On Tue, Jul 16, 2019 at 12:09 PM Man Cao <manc at google.com> wrote:

> I cannot build TSAN after
> http://hg.openjdk.java.net/tsan/dev/rev/3bae5ecee45f. I'm seeing the
> following errors:
>
> In file included from
> /usr/local/google/home/manc/ws/tsan/src/hotspot/share/tsan/tsan.cpp:26:
>
> /usr/local/google/home/manc/ws/tsan/src/hotspot/share/classfile/tsanIgnoreList.hpp:45:24:
> error: expected class name
> class TsanIgnoreList : AllStatic {
>                        ^
>
> /usr/local/google/home/manc/ws/tsan/src/hotspot/share/classfile/tsanIgnoreList.hpp:54:27:
> error: unknown type name 'Symbol'
>   static bool match(const Symbol* class_name, const Symbol* field_name,
>                           ^
>
> /usr/local/google/home/manc/ws/tsan/src/hotspot/share/classfile/tsanIgnoreList.hpp:54:53:
> error: unknown type name 'Symbol'
>   static bool match(const Symbol* class_name, const Symbol* field_name,
>                                                     ^
>
> /usr/local/google/home/manc/ws/tsan/src/hotspot/share/classfile/tsanIgnoreList.hpp:55:21:
> error: unknown type name 'BasicType'
>                     BasicType type);
>                     ^
>
> /usr/local/google/home/manc/ws/tsan/src/hotspot/share/classfile/tsanIgnoreList.hpp:58:31:
> error: unknown type name 'FILE'
>   static void parse_from_file(FILE* stream);
>                               ^
> In file included from
>
> /usr/local/google/home/manc/ws/tsan/src/hotspot/share/classfile/tsanIgnoreList.cpp:27:
>
> /usr/local/google/home/manc/ws/tsan/src/hotspot/share/classfile/tsanIgnoreList.hpp:45:24:
> error: expected class name
> class TsanIgnoreList : AllStatic {
>                        ^
>
> /usr/local/google/home/manc/ws/tsan/src/hotspot/share/classfile/tsanIgnoreList.hpp:54:27:
> error: unknown type name 'Symbol'
>   static bool match(const Symbol* class_name, const Symbol* field_name,
>                           ^
>
> /usr/local/google/home/manc/ws/tsan/src/hotspot/share/classfile/tsanIgnoreList.hpp:54:53:
> error: unknown type name 'Symbol'
>   static bool match(const Symbol* class_name, const Symbol* field_name,
>                                                     ^
>
> /usr/local/google/home/manc/ws/tsan/src/hotspot/share/classfile/tsanIgnoreList.hpp:55:21:
> error: unknown type name 'BasicType'
>                     BasicType type);
>                     ^
>
> /usr/local/google/home/manc/ws/tsan/src/hotspot/share/classfile/tsanIgnoreList.hpp:58:31:
> error: unknown type name 'FILE'
>   static void parse_from_file(FILE* stream);
> ...
>
> Also, can we move tsanIgnoreList.hpp/cpp to the hotspot/share/tsan
> directory?
>
> -Man
>


More information about the tsan-dev mailing list