[RFR]: Suppress some String races

Man Cao manc at google.com
Mon Jun 24 18:31:04 UTC 2019


Can we change the comment in the string content to C/C++ comment?
Also, please clarify the comments like the following:
"# SoftReference.timestamp\n"
"# String.hash\n"
"# java.lang.StringLatin1.charAt\n"

-Man


On Mon, Jun 24, 2019 at 9:58 AM Jean Christophe Beyler <jcbeyler at google.com>
wrote:

> LGTM,
> Jc
>
> On Sun, Jun 23, 2019 at 2:12 PM Arthur Eubanks <aeubanks at google.com>
> wrote:
>
> > Webrev:
> > http://cr.openjdk.java.net/~aeubanks/tsanstring/webrev.00/index.html
> >
> > Some common String operations are racy, e.g. hashCode or concatenation.
> > These races should be suppressed, since they are in the JDK.
> > This change adds a test that calls hashCode() on a const String and does
> > local String concatenation.
> >
>
>
> --
>
> Thanks,
> Jc
>


More information about the tsan-dev mailing list