[RFR] Ignore fields annotated with @LazyInit

Jean Christophe Beyler jcbeyler at google.com
Tue Jun 25 22:42:03 UTC 2019


Looks good to me too,

My only comment would be here:
http://cr.openjdk.java.net/~aeubanks/tsanfieldignore/webrev.01/src/hotspot/share/interpreter/interpreterRuntime.cpp.udiff.html

This could be:


+  bool is_tsan_ignore = false;+#if INCLUDE_TSAN+  is_tsan_ignore =
info.access_flags().is_stable() ||
info.access_flags().is_tsan_ignore();+#endif  // INCLUDE_TSAN+

No need of a new webrev either way :)

Jc


On Mon, Jun 24, 2019 at 2:11 PM Arthur Eubanks <aeubanks at google.com> wrote:

> >
> > Looks good. One minor comment is the VM symbol
> > java_util_concurrent_atomic_annotation_LazyInit, can we remove "atomic_"
> > from the name?
> >
> Done.
>
> New webrev:
> http://cr.openjdk.java.net/~aeubanks/tsanfieldignore/webrev.01/index.html
>


-- 

Thanks,
Jc


More information about the tsan-dev mailing list