RFR (M): First JTREG Tsan test

Daniil Titov daniil.x.titov at oracle.com
Fri Mar 22 02:32:35 UTC 2019


Hi JC,

The change looks good to me.

Thanks!
-Daniil


On 3/21/19, 1:13 PM, "tsan-dev on behalf of Jean Christophe Beyler" <tsan-dev-bounces at openjdk.java.net on behalf of jcbeyler at google.com> wrote:

    Typo, should be unexpectedly :)
    
    Fixed on my local version,
    Jc
    
    On Thu, Mar 21, 2019 at 1:03 PM Arthur Eubanks <aeubanks at google.com> wrote:
    
    > "unexpectantly" isn't a real word :P
    > LGTM otherwise
    >
    > On Thu, Mar 21, 2019 at 1:00 PM Jean Christophe Beyler <
    > jcbeyler at google.com> wrote:
    >
    >> Done for the symmetric; I actually now just added the code to check that
    >> it does fail. When TSAN will be up and running, this will trip the test and
    >> start failing so we can update it automatically then. Let me know what you
    >> think:
    >>
    >> Webrev: http://cr.openjdk.java.net/~jcbeyler/first_test/webrev.01/
    >>
    >> Jc
    >>
    >> On Thu, Mar 21, 2019 at 12:47 PM Arthur Eubanks <aeubanks at google.com>
    >> wrote:
    >>
    >>> Remove the "symmetric behavior" comment in AbstractLoop.java.
    >>> Do we need "requires vm.compMode == "Xint"" in the test?
    >>> The test should check that the return code is non-zero.
    >>>
    >>> On Thu, Mar 21, 2019 at 10:49 AM Jean Christophe Beyler <
    >>> jcbeyler at google.com> wrote:
    >>>
    >>>> Hi all,
    >>>>
    >>>> Could I get a review for this:
    >>>> http://cr.openjdk.java.net/~jcbeyler/first_test/webrev.00/
    >>>>
    >>>> It basically creates a simple racy test and adds the JTREG
    >>>> infrastructure
    >>>> to make future tests easy to write.
    >>>>
    >>>> Note: the test evidently fails until we get Tsan in any kind of shape
    >>>> but
    >>>> this will allow me to write up some documentation on the wiki page once
    >>>> pushed. :-)
    >>>>
    >>>> Thanks,
    >>>> Jc
    >>>>
    >>>
    >>
    >> --
    >>
    >> Thanks,
    >> Jc
    >>
    >
    
    -- 
    
    Thanks,
    Jc
    
    




More information about the tsan-dev mailing list