RFR (M): First JTREG Tsan test

Man Cao manc at google.com
Fri Mar 22 17:49:43 UTC 2019


LGTM after fixing these. No need for new webrev.

-Man


On Fri, Mar 22, 2019 at 10:32 AM Jean Christophe Beyler <jcbeyler at google.com>
wrote:

> Yes for the webrev :)
> Done for both :)
>
> One day the @require will have to come back when we are adding C1 support
> for example but we can deal with that later.
>
> Want to see the new webrev or good to go on your side apart from those two
> elements?
> Jc
>
> On Fri, Mar 22, 2019 at 10:21 AM Man Cao <manc at google.com> wrote:
>
>> Thanks for the instructions!
>> I assume this is the webrev that you intended to include in last email:
>> http://cr.openjdk.java.net/~jcbeyler/first_test/webrev.02.
>>
>> It confused me initially that it has both "@requires vm.compMode ==
>> "Xint"" and "@run main/othervm -Xint ...". Can we only have one of them?
>> "@requires" needs more typing when running the test. But if TSAN supports
>> C1 or other compilers, it might be easier to modify all "@requires" than
>> all "@run".
>>
>> Also, "@compile RacyIntMemberLoopTest.java" seems unnecessary and can be
>> removed.
>>
>> -Man
>>
>
>
> --
>
> Thanks,
> Jc
>


More information about the tsan-dev mailing list