[RFR] Create interface to call TSAN runtime

[Jean Christophe Beyler]

Looks good again except that now :


  33 // These declarations, along with TsanSymbolizeStackFrame, constitute
the
  34 // VM-ThreadSanitizer interface. These functions are the only way the
VM
  35 // notifies Tsan about critical events; they are "push" functions.
  36 // (TSAN calls TsanSymbolizeStackFrame when it prints stack traces).
  37 //

  42 // The __tsan_java_* functions accept a raw oop as an argument; Tsan tracks
  43 // metadata for each oop using fixed address offsets.


Make no real sense when you read the file; they should be added later :-)


No need for a new webrev btw,

Jc


On Mon, Mar 25, 2019 at 11:13 AM Arthur Eubanks <aeubanks at google.com> wrote:

> My only nit would be that your file:
>>
>> http://cr.openjdk.java.net/~aeubanks/tsaninit/webrev.00/src/hotspot/share/runtime/tsanExternalDecls.hpp.html
>>
>> contains all the methods we use. Would we want to add into it
>> incrementally instead? I'm indifferent both ways, just wondering :)
>>
> Hmm, I suppose it would make more sense to add them incrementally. Changed.
> http://cr.openjdk.java.net/~aeubanks/tsaninit/webrev.01/
>


-- 

Thanks,
Jc