[RFR]: Fix broken build

Jean Christophe Beyler jcbeyler at google.com
Thu Mar 28 02:28:36 UTC 2019


LGTM,
Jc

On Wed, Mar 27, 2019 at 4:37 PM Man Cao <manc at google.com> wrote:

> Looks good.
> -Man
>
>
> On Wed, Mar 27, 2019 at 4:34 PM Arthur Eubanks <aeubanks at google.com>
> wrote:
>
> > The previous change is broken (I thought I tested it...) due to a type
> that
> > the JVM doesn't recognize. int64 -> julong.
> >
> > diff --git a/src/hotspot/share/runtime/tsan.cpp
> > b/src/hotspot/share/runtime/tsan.cpp
> > --- a/src/hotspot/share/runtime/tsan.cpp
> > +++ b/src/hotspot/share/runtime/tsan.cpp
> > @@ -58,7 +58,7 @@ typedef void (*AddFrameFunc)(void *ctx,
> >  // This is not in tsanExternalDecls.hpp because this is a function that
> > the JVM
> >  // is supposed to override which TSAN will call, not a TSAN function
> that
> > the
> >  // JVM calls.
> > -extern "C" void __tsan_symbolize_external_ex(int64 pc,
> > +extern "C" void __tsan_symbolize_external_ex(julong pc,
> >                                               AddFrameFunc addFrame,
> >                                               void *ctx) {
> >
>


-- 

Thanks,
Jc


More information about the tsan-dev mailing list