[RFR]: Interpreter method entry/exit
Man Cao
manc at google.com
Thu Mar 28 20:53:58 UTC 2019
Looks good, except "debug_only" could be changed to "DEBUG_ONLY"
in sharedRuntime.cpp.
No need for a new webrev.
-Man
On Thu, Mar 28, 2019 at 8:49 AM Jean Christophe Beyler <jcbeyler at google.com>
wrote:
> Hi Arthur,
>
> Yes, the access issues were due to maintenance :); I had seen the email but
> had not connected the two until other webrevs (including my own!) were not
> available :)
>
> For now it looks good to me to get us going; I wonder if there is a way to
> piggy back JVMTI's infrastructure since they have the method entry/exit in
> the right spots. But I'm not sure how that would really look like and is it
> logical to do so; perhaps we could at least check at some point that each
> JVMTI point of call, we do it as well :)
>
> So, LGTM,
> Jc
>
> On Wed, Mar 27, 2019 at 9:57 PM Arthur Eubanks <aeubanks at google.com>
> wrote:
>
> > There seems to be a permission issue with your webrev?
> >>
> > All of my webrevs are down from the webpage even though I can see them
> > from ftp. I think it's a transient issue, we'll see tomorrow.
> >
> >>
> >> Btw, are you by chance updating the wiki with the commands to be run now
> >> or should I do it at some point in the future?
> >> Jc
> >>
> > I'll update the wiki in a separate change.
> >
>
>
> --
>
> Thanks,
> Jc
>
More information about the tsan-dev
mailing list