RFR (M): Make TSAN a build-time JVM feature

[Jean Christophe Beyler]

Agreed Man on all points,

LGTM,
Jc

On Fri, Mar 29, 2019 at 7:14 PM Man Cao <manc at google.com> wrote:

> Note that I moved the two new files for TSAN into the directory
> "share/tsan".
> Looking at our internal TSAN code, there will be more new files for TSAN to
> add in the future. A separate directory seems cleaner.
>
> -Man
>
>
> On Fri, Mar 29, 2019 at 7:10 PM Man Cao <manc at google.com> wrote:
>
> > Hi,
> >
> > Could I get review for this:
> > http://cr.openjdk.java.net/~manc/tsan/20190329/webrev.00/
> >
> > It makes it possible to disable TSAN at build time, using
> > "--with-jvm-features=-tsan". My initial purpose was to add a "#ifdef"
> macro
> > for TSAN, but it seems making TSAN a JVM feature is the right way to go
> for
> > the long term.
> >
> > Tested by building with and without TSAN, and running LD_PRELOAD.
> >
> > -Man
> >
>


-- 

Thanks,
Jc