RFR (M): Use TSAN_RUNTIME_ONLY for most instrumentation
Arthur Eubanks
aeubanks at google.com
Mon May 6 16:57:42 UTC 2019
Having to type "__FILE__, __LINE__" to every TsanRawLock*() call is
annoying. Is it possible to still keep the TSAN_RAW_LOCK_* macros in
tsan.hpp and call them in a TSAN_RUNTIME_ONLY block? That way they're
stripped out by the preprocessor in non-TSAN builds, and they'll still be
available in TSAN builds.
*From: *Man Cao <manc at google.com>
*Date: *Mon, May 6, 2019 at 9:48 AM
*To: * <tsan-dev at openjdk.java.net>
Hi all,
>
> Can I have reviews for this bug fix and cleanup?
> http://cr.openjdk.java.net/~manc/tsan/20190506/webrev.00/
>
> Copying commit message below:
> Use TSAN_RUNTIME_ONLY for most instrumentation.
> This fixes build error using --with-jvm-features=-tsan,
> and reduces boilerplate code for instrumentation.
> Also simplified oopDesc:is_oop() uses and updated a comment.
>
> -Man
>
More information about the tsan-dev
mailing list