RFR: Add function entry/exit instruments for aarch64

Arthur Eubanks aeubanks at openjdk.java.net
Wed Apr 29 16:02:51 UTC 2020


On Wed, 29 Apr 2020 10:19:27 GMT, Jie He <github.com+10233373+jhe33 at openjdk.org> wrote:

> Add function entry/exit instruments for aarch64, including 3 places:
> gernate_normal_entry, generate_native_entry and generate_native_wrapper.
> 
> PS, I'm not sure if it's neccessary to instrument tsan into
> generate_native_wrapper, which is for compiled code. Now just follow x86.
> In addition, all tsan test cases could pass even though I remove the
> instruments in generate_native_wrapper.

The commit LGTM, but I have some questions about your comment.

1) You mentioned generate_native_entry, but I don't see that in the commit anywhere.
2) I think generate_native_wrapper is necessary to make tests like RacyNativeLoopTest.java pass, I'd be surprised if it
wasn't necessary.

-------------

PR: https://git.openjdk.java.net/tsan/pull/7


More information about the tsan-dev mailing list