RFR: Enable array access instrumentation for aarch64

[eric.1iu]

On Thu, 28 May 2020 17:41:49 GMT, Arthur Eubanks <aeubanks at openjdk.org> wrote:

>> This patch is a subsequent patch of https://github.com/openjdk/tsan/pull/11.
>> 
>> This patch inserts TSAN instrumentation in interpreter at array access
>> bytecodes like below:
>> 
>> - aaload, baload, caload, daload, iaload, laload, saload
>> - aastore, bastore, castore, dastore, iastore, lastore, sastore
>> 
>> Besides those normal array access bytecodes, some fast bytecodes (e.g.
>> fast_icaload) would result in memory access as well. TSAN has disabled
>> bytecode rewrite in previous patch. This patch inserts assertions
>> in 'fast_xaccess', 'fast_accessfield' and 'fast_icaload' to make sure
>> that TSAN would not reach there.
>> 
>> 
>> [TEST]
>> With this patch, all TSAN test cases passed both on x86 and aarch64.
>
> LGTM
> 
> Exciting that all the tests pass now! Is there any follow up work after this? (Except of course the monumental task of
> upstreaming this into jdk/jdk)

Hi Arthur,

Thanks for your review.

We (@jhe33 @erik1iu ) will do more testing about TSAN recently, and also intend to spend some time to investigate if
it's possible to enable TSAN in C1 compiler. I suppose there would not have patch delivery in the short term.

Finally, thanks for your (your team's) pre-investigation and lots of common works on TSAN, which is a great work for
the whole project and gives us great help.

B&R
Eric

-------------

PR: https://git.openjdk.java.net/tsan/pull/13