RFR: 8336924: Disable jcheck for referencing an issue number in commit message title.

Liam Miller-Cushon cushon at openjdk.org
Mon Jul 22 18:20:22 UTC 2024


On Sat, 20 Jul 2024 00:29:29 GMT, Man Cao <manc at openjdk.org> wrote:

> Hi all,
> 
> https://github.com/openjdk/tsan/pull/19 sees a jcheck error "The commit message does not reference any issue. To add an issue reference to this PR, edit the title to be of the format issue number: message."
> TSAN project currently does not need an issue for a commit, so I propose we disable this check.
> 
> The jcheck was probably enabled in Sep, 2020 by https://github.com/openjdk/tsan/commit/e0c8d4420c8e1a84581927cf77314498b8e5aa52.  However, TSAN project did not have new PRs except merges after Sep, 2020. (I think this check probably skips checking merge commits and merge PRs.)
> 
> -Man

LGTM

I wondered if you could unblock it by filing an actual bug for this one PR and using that in the title?

-------------

Marked as reviewed by cushon (Reviewer).

PR Review: https://git.openjdk.org/tsan/pull/20#pullrequestreview-2189578712
PR Comment: https://git.openjdk.org/tsan/pull/20#issuecomment-2240824506


More information about the tsan-dev mailing list