RFR: Reimplement TsanOopMap support using WeakHandle and ResizeableResourceHashtable [v3]

Jiangli Zhou jiangli at openjdk.org
Tue Jul 23 22:58:40 UTC 2024


On Tue, 23 Jul 2024 00:48:43 GMT, Man Cao <manc at openjdk.org> wrote:

>> Jiangli Zhou has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove TsanOopBitMap. We can use CHeapBitMap instead. Thanks manc@ for catching it in https://github.com/openjdk/tsan/pull/19/files#r1687286079.
>
> src/hotspot/share/tsan/tsanOopMap.cpp line 240:
> 
>> 238:           // Indicate that this move has been done and remember that we
>> 239:           // made some progress.
>> 240:           m.n_bytes = 0;
> 
> I have not looked into it deeply, but could you summarize the difference between `find_first_set_bit` and JDK 11's `get_next_one_offset`? I thought `find_first_set_bit` does the same thing.

Thanks for catching this! I had forgotten that `find_first_set_bit|get_next_one_offset` changes has already resolved and merged.

I've removed `TsanOopBitMap` completely. This is cleaner now.

-------------

PR Review Comment: https://git.openjdk.org/tsan/pull/19#discussion_r1688808837


More information about the tsan-dev mailing list