RFR: Reimplement TsanOopMap support using WeakHandle and ResizeableResourceHashtable [v6]

Jiangli Zhou jiangli at openjdk.org
Wed Jul 24 18:53:51 UTC 2024


On Wed, 24 Jul 2024 02:02:05 GMT, Man Cao <manc at openjdk.org> wrote:

>> Jiangli Zhou has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Sort moves for overlapping case only.
>
> src/hotspot/share/tsan/tsanOopMapTable.cpp line 49:
> 
>> 47: 
>> 48: void TsanOopMapTableKey::update_obj() {
>> 49:   oop obj = _wh.peek();
> 
> Since `_obj` is `oopDesc*` and `oop` could be an object, is it better to do `oopDesc* obj = _wh.peek()`?

`oopDesc*` is `oop`.

-------------

PR Review Comment: https://git.openjdk.org/tsan/pull/19#discussion_r1690283269


More information about the tsan-dev mailing list