RFR: Reimplement TsanOopMap support using WeakHandle and ResizeableResourceHashtable [v6]
Man Cao
manc at openjdk.org
Thu Jul 25 01:28:47 UTC 2024
On Wed, 24 Jul 2024 20:10:39 GMT, Man Cao <manc at openjdk.org> wrote:
>> `oopDesc*` is `oop`.
>
> `oopDesc*` is different from `oop` in a fastdebug build, when `CHECK_UNHANDLED_OOPS` is defined.
See the `oop` class definition [here](https://github.com/openjdk/jdk/blob/0898ab7f7496689e5de52a5dc4530ca21def1fca/src/hotspot/share/oops/oopsHierarchy.hpp#L53-L115). Note that `CHECK_UNHANDLED_OOPS` is only enabled in [fastdebug](https://github.com/openjdk/jdk/blob/0898ab7f7496689e5de52a5dc4530ca21def1fca/make/hotspot/lib/JvmFlags.gmk#L77-L81), not slowdebug.
As said in the other comment, we could declare `TsanOopMapTableKey::_obj` as an `oop`, but make sure to test with fastdebug build.
-------------
PR Review Comment: https://git.openjdk.org/tsan/pull/19#discussion_r1690669797
More information about the tsan-dev
mailing list