RFR: Reimplement TsanOopMap support using WeakHandle and ResizeableResourceHashtable [v11]

Jiangli Zhou jiangli at openjdk.org
Mon Jul 29 19:31:46 UTC 2024


On Sat, 27 Jul 2024 03:27:15 GMT, Man Cao <manc at openjdk.org> wrote:

>> Jiangli Zhou has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   - Use cast_from_oop<T> in various places when coverting oop to different types.
>>   - Change TsanOopMapTableKey::_obj to 'oop'.
>>   - Change TsanOopMapTableKey::equals to just do `lhs._obj == rhs._obj`.
>
> src/hotspot/share/tsan/tsanOopMapTable.cpp line 85:
> 
>> 83:   if (added) {
>> 84:     if (_table.maybe_grow(true /* use_large_table_sizes */)) {
>> 85:       log_info(tsan)("TsanOopMapTable resize to %d, %d entries",
> 
> Could it be `log_debug(tsan)` as well?

Let's keep `log_info`. Resizing occurs not frequently, there's no concern with too much resizing log output. The resizing info maybe useful for finding more adequate table size.

-------------

PR Review Comment: https://git.openjdk.org/tsan/pull/19#discussion_r1695758029


More information about the tsan-dev mailing list