javadoc JDK 8 build dependency

[Werner Dietl]

Jon,

> Can you point out where you are using reflection to work around the
> compile-time issue?

In com.sun.tools.doclets.internal.toolkit.util.Util I added method
getElementTypeTypeUse() that uses

ElementType.valueOf("TYPE_USE")

instead of direct accesses to the new TYPE_USE constant.
(Does this qualify as reflection? Maybe there is a better term for
accessing an enum constant like this?)

Using this method allows the bootstrap compilation of langtools, but
then when the jdk build uses javadoc, we need to ensure that the
TYPE_USE enum constant is actually there.
I recently pushed this change to the jdk build file and the forest now
builds correctly for me:

http://buffalo.cs.washington.edu:8080/job/type-annotations/lastBuild/console

Do let me know whether you see a different fix for this issue.

Best regards,
cu, WMD.


> On 04/30/2012 10:21 PM, Werner Dietl wrote:
>>
>> Dear fellow type annotations developers,
>>
>> currently building the JDK documentation fails, because javadoc now
>> uses the ElementTypes.TYPE_USE field. We prevent the static compile
>> error by looking up the field via reflection; however, we also need to
>> adapt the classpath at execution time to use the correct version of
>> ElementTypes.
>> I propose the following simple change:
>>
>>
>> diff --git a/make/common/shared/Defs-java.gmk
>> b/make/common/shared/Defs-java.gmk
>> --- a/make/common/shared/Defs-java.gmk
>> +++ b/make/common/shared/Defs-java.gmk
>> @@ -178,7 +178,7 @@
>>
>>  "-Xbootclasspath/p:$(JAVAH_JAR)$(CLASSPATH_SEPARATOR)$(JAVAC_JAR)"  \
>>                -jar $(JAVAH_JAR) $(JAVAHFLAGS)
>>    JAVADOC_CMD = $(BOOT_JAVA_CMD) \
>> -
>> "-Xbootclasspath/p:$(JAVADOC_JAR)$(CLASSPATH_SEPARATOR)$(JAVAC_JAR)$(CLASSPATH_SEPARATOR)$(DOCLETS_JAR)"
>> \
>> +
>> "-Xbootclasspath/p:$(CLASSBINDIR)$(CLASSPATH_SEPARATOR)$(JAVADOC_JAR)$(CLASSPATH_SEPARATOR)$(JAVAC_JAR)$(CLASSPATH_SEPARATOR)$(DOCLETS_JAR)"
>> \
>>                -jar $(JAVADOC_JAR) $(JAVADOCFLAGS)
>>  else
>>    # If no explicit tools, use boot tools (add VM flags in this case)
>>
>>
>> Please do let me know if you're not running into this build problem
>> and I'll investigate my setup.
>> Is this an acceptable additional build dependency?
>> Could you update me on the build status on the Oracle servers?
>>
>> Thanks and best regards,
>> cu, WMD.
>>
>



-- 
http://www.google.com/profiles/wdietl