RFR: fix for repeating annotations on type parameter args

Joel Borggrén-Franck joel.franck at oracle.com
Fri Apr 26 00:19:41 PDT 2013


I used a script to transform the javap output to the required format, I 
agree with you the indentation looks off by one in some places in the test file.

cheers
/Joel

On 04/26/2013 05:26 AM, Werner Dietl wrote:
> Hi Joel,
>
>>> Some of the changes in Gen.java and RepeatingTypeAnnotations.java use
>>> too much indentation.
>>>
>>
>> I'm fairly certain it is the other way around, old code using an indent of 3
>> spaces.
>
> Looking at the patch you pushed today:
>
> http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/file/ac33d03e35b8/test/tools/javap/output/RepeatingTypeAnnotations.java
>
> http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/diff/ac33d03e35b8/test/tools/javap/output/RepeatingTypeAnnotations.java
>
> To me, the indentation seems inconsistent, starting with the change on line 331.
> It looks inconsistent in the patch and the final file.
> Does it look differently for you?
>
> cu, WMD.
>
> --
> http://www.google.com/profiles/wdietl
>


More information about the type-annotations-dev mailing list